Okay
  Public Ticket #1199748
PHP7
Closed

Comments

  •  21
    Simon started the conversation
    June 8, 2017 at 2:21pm

    The theme is triggering a few PHP7 errors and warnings as per the PHP compatibility checker - do you know if these will be fixed and whether they should prevent an upgrade?

    Many thanks, Si



    FILE: /nas/content/live/maffetone/wp-content/themes/salient/nectar/redux-framework/ReduxCore/inc/validation/preg_replace/validation_preg_replace.php
    ----------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------------------------------
     30 | ERROR | preg_replace() - /e modifier is deprecated since PHP 5.5 and removed since PHP 7.0
    ----------------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /nas/content/live/maffetone/wp-content/themes/salient/nectar/redux-framework/ReduxCore/inc/browser.php
    ------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------------
     191 | WARNING | Use of deprecated PHP4 style class constructor is not supported since PHP 7.
    ------------------------------------------------------------------------------------------------------------

    FILE: /nas/content/live/maffetone/wp-content/themes/salient/nectar/redux-framework/extensions/wbc_importer/inc/importer/wordpress-importer.php
    ----------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------------------------
     66 | WARNING | Use of deprecated PHP4 style class constructor is not supported since PHP 7.
    ----------------------------------------------------------------------------------------------------------------------------------------------


  •  9,013
    Tahir replied
    June 9, 2017 at 11:33am

    Hey Again,

    Assigning this Ticket to the Developer so he can add in a response . 

    Thanks 

    ThemeNectar Support Team 

  • Collin replied
    June 13, 2017 at 7:43pm

    Just adding that we're also seeing PHP7 compatibility issues with the redux framework. Will this be updated soon?

    Thank you!

  •  1
    clixgroup replied
    July 18, 2017 at 4:49pm

    I just ran the theme through the WPE PHP compatibility checker and there are a few flags (I am running Salient 8.0.16).


    Theme Issues:

    FILE: /nas/content/live/helibacon/wp-content/themes/salient/nectar/redux-framework/ReduxCore/inc/browser.php
    ------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------------
     191 | WARNING | Use of deprecated PHP4 style class constructor is not supported since PHP 7.
    ------------------------------------------------------------------------------------------------------------

    FILE: /nas/content/live/helibacon/wp-content/themes/salient/nectar/redux-framework/ReduxCore/inc/validation/preg_replace/validation_preg_replace.php
    ----------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------------------------------
     30 | ERROR | preg_replace() - /e modifier is deprecated since PHP 5.5 and removed since PHP 7.0
    ----------------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /nas/content/live/helibacon/wp-content/themes/salient/nectar/redux-framework/extensions/wbc_importer/inc/importer/wordpress-importer.php
    ----------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------------------------
     66 | WARNING | Use of deprecated PHP4 style class constructor is not supported since PHP 7.
    ----------------------------------------------------------------------------------------------------------------------------------------------


    &

    VC Issues:

    FILE: /nas/content/live/helibacon/wp-content/plugins/js_composer_salient/js_composer.php
    ----------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------
     222 | ERROR | Visibility for magic method __sleep must be public. Found: private
    ----------------------------------------------------------------------------------------

    FILE: /nas/content/live/helibacon/wp-content/plugins/js_composer_salient/include/templates/editors/partials/backend-shortcodes-templates.tpl.php
    --------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------------------------------------------------------------------------------
     44 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= type %>">
     45 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= heading %></div>
     47 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= form_element %>
    --------------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /nas/content/live/helibacon/wp-content/plugins/js_composer_salient/include/templates/editors/popups/shared-templates/category.tpl.php
    -------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
    -------------------------------------------------------------------------------------------------------------------------------------------------------------
     134 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%- post_id %>"
     135 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%- title %>"
     141 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%- title %></button>
     149 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%- post_id %>"]" titl...
     160 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%- id %>">
     162 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%- thumbnailUrl %>" alt=""...
     165 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%- previewUrl %>" data-tit...
     167 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% if (!downloaded) { %>
     171 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% } else if (downloaded &&...
     175 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <% } %>
     180 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%- title %></span>
     182 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= status %>
    -------------------------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /nas/content/live/helibacon/wp-content/plugins/js_composer_salient/include/templates/teaser.html.php
    ------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------------------------------------------------------------
     84 | WARNING | Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found: <%= id %>" src="<%= url %>"...
    ------------------------------------------------------------------------------------------------------------------------------------------------------------